gh-82129: Improve annotations for make_dataclass()#133406
Merged
+98 −13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…wt3u.rst Co-authored-by: Carl Meyer <carl@oddbird.net>
| try: | ||
| ann=_get_dunder_annotations(obj) | ||
| exceptNameError: | ||
| exceptException: |
MemberAuthor
There was a problem hiding this comment.
I made a separate PR (with tests) for this change in #133407.
sobolevn reviewed May 4, 2025
Member
sobolevn left a comment
sobolevn left a comment There was a problem hiding this comment.
Thank you for reviving this PR! It looks like it achieves its main goal.
JelleZijlstra merged commit bb5ec6e into python:main 45 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Carl Meyer <carl@oddbird.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#82129. Closes#122262.
This is on top of @sobolevn's #122262 but jumps through a few more hoops to achieve these goals:
make_dataclass()are sensible in all formats