Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-133447: Add basic color to sqlite3 CLI#133461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
StanFromIreland commented May 5, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
sharktide left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me
tomasr8 commented May 6, 2025
Now that #133347 has been merged, we could take advantage of it in the sqlite CLI as well? |
StanFromIreland commented May 6, 2025
cc @ambv Just to check -- did I use themes correctly or did I do something wrong (there is no docs at the moment to verify)? |
ambv left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there are no docs so I'll push here with how I'd do it if that's okay.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ambv left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
StanFromIreland commented May 6, 2025
Looks good to me now, thank you for the assistance:-) If you need help with colorise I’d be happy to lend a hand. |
ambv commented May 6, 2025
Excellent! Since all this is already for 3.15, I think we might attempt a SQL syntax highlighter as well, although I'm not entirely sure our tokenizer will take kindly to it, so this might become a larger task. We have plenty of time, though. |
sqlite3 clisqlite3 CLIUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland commented May 7, 2025
SQL highlighting would be awesome. |
StanFromIreland commented May 7, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
All the test fails are unrelated.
Working on it :-) |
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland commented May 10, 2025
@StanFromIreland, please look into the failing tests. |
StanFromIreland commented May 10, 2025
I was testing the broken behavior that was now fixed, oops! |
StanFromIreland commented May 10, 2025
@erlend-aasland Test has been corrected to work with the new updates. |
30b1d8f into python:mainUh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented May 10, 2025
|
StanFromIreland commented May 10, 2025
Unrelated. |
Uh oh!
There was an error while loading. Please reload this page.
(pythongh-133447: Add basic color to `sqlite3` CLI (python#133461))
request: @hugovk