Skip to content

gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)"#133497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 1 commit into from
May 6, 2025
Merged

gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)" #133497

hugovk merged 1 commit into from
May 6, 2025

Conversation

@encukou
Copy link
Member

@encukouencukou commented May 6, 2025•
edited by bedevere-app bot
Loading

This reverts commit d270bb5.

Note that the test functions in _code_definitions are not reverted.

@encukou
Revert "pythongh-132775: Add _PyCode_VerifyStateless() (pythongh-133221…
e7d7e26
…)" This reverts commit d270bb5. Note that the test functions in _code_definitions are not reverted.
@encukouencukou requested a review from markshannon as a code ownerMay 6, 2025 07:19
@bedevere-appbedevere-appbot mentioned this pull request May 6, 2025
Closed
@encukouencukou changed the title Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)"gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (gh-133221)"May 6, 2025
@encukou
Copy link
MemberAuthor

encukou commented May 6, 2025

@hugovk I need to step away for a doctor's appointment. Here's what I have, I haven't checked this very well.

@hugovk
Copy link
Member

hugovk commented May 6, 2025

@encukou Thank you!

@hugovk
Copy link
Member

hugovk commented May 6, 2025

!buildbot ios

@bedevere-bot
Copy link

bedevere-bot commented May 6, 2025

🤖 New build scheduled with the buildbot fleet by @hugovk for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: ios

The builders matched are:

  • iOS ARM64 Simulator PR

@hugovk
Copy link
Member

hugovk commented May 6, 2025

!buildbot android

@bedevere-bot
Copy link

bedevere-bot commented May 6, 2025

🤖 New build scheduled with the buildbot fleet by @hugovk for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@ambv
Copy link
Contributor

ambv commented May 6, 2025

iOS buildbot green! No Android results yet.

@ambv
Copy link
Contributor

ambv commented May 6, 2025

It's weird since the Android builders aren't building anything else at the moment. Looking at buildmaster.

@ambv
Copy link
Contributor

ambv commented May 6, 2025

Master claims it added jobs:

2025-05-06 07:36:07+0000 [HTTP11ClientProtocol (BufferingTLSTransport),client] Received 1 changes from GitHub PR #133497 2025-05-06 07:36:07+0000 [-] added change with revision e7d7e26eee5fa9dcd6b23d1dd00f96cd083aff8b to database 2025-05-06 07:36:07+0000 [-] injected change 41998

Weird. Let's try again.

@ambv
Copy link
Contributor

ambv commented May 6, 2025

!buildbot android

@bedevere-bot
Copy link

bedevere-bot commented May 6, 2025

🤖 New build scheduled with the buildbot fleet by @ambv for commit e7d7e26 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133497%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@ambv
Copy link
Contributor

ambv commented May 6, 2025

Now it worked, builds started.

@hugovk
Copy link
Member

hugovk commented May 6, 2025

And Android green.

@hugovkhugovk merged commit 3c73cf5 into python:mainMay 6, 2025
45 checks passed
This was referenced May 6, 2025
Merged
Merged
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 6, 2025
@ericsnowcurrently
Revert "pythongh-132775: Revert "pythongh-132775: Add _PyCode_VerifyS…
eab4c13
…tateless() (pythongh-133221)" (python#133497)" This reverts commit 3c73cf5.
This was referenced May 6, 2025
Merged
Merged
ericsnowcurrently added a commit that referenced this pull request May 8, 2025
@ericsnowcurrently
gh-132775: Unrevert "Add _PyCode_VerifyStateless()" (gh-133528)
27128e4
This reverts commit 3c73cf5 (gh-133497), which itself reverted the original commit d270bb5 (gh-133221). We reverted the original change due to failing android tests. The checks in _PyCode_CheckNoInternalState() were too strict, so we've relaxed them.
ericsnowcurrently added a commit that referenced this pull request May 8, 2025
@ericsnowcurrently
[3.14]gh-132775: Unrevert "Add _PyCode_VerifyStateless()" (gh-133625)
c39bc81
This reverts commit 3c73cf5 (gh-133497), which itself reverted the original commit d270bb5 (gh-133221). We reverted the original change due to failing android tests. The checks in _PyCode_CheckNoInternalState() were too strict, so we've relaxed them.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou@Pranjal095
pythongh-132775: Revert "pythongh-132775: Add _PyCode_VerifyStateless…
eec7b86
…() (pythongh-133221)" (python#133497)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@ericsnowcurrently@Pranjal095
pythongh-132775: Unrevert "Add _PyCode_VerifyStateless()" (pythongh-1…
3bea157
…33528) This reverts commit 3c73cf5 (pythongh-133497), which itself reverted the original commit d270bb5 (pythongh-133221). We reverted the original change due to failing android tests. The checks in _PyCode_CheckNoInternalState() were too strict, so we've relaxed them.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou@hugovk@bedevere-bot@ambv