gh-106213: Shorten Emscripten wasm-gc trampoline by a little#133984
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I found out about the `if` instruction which lets us have slightly shorter code here.
hoodmaneforce-pushed the shorter-emscripten-wasm-gc-trampoline branch from 5680660 to de6ffa6Comparehoodmane changed the title hoodmane changed the title 
freakboy3742 changed the title 
freakboy3742 merged commit 3b7888b into python:main 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
…ythonGH-133984) Using the if instruction results in slightly shorter trampoline code. (cherry picked from commit 3b7888b) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
GH-134376 is a backport of this pull request to the 3.14 branch. |
freakboy3742 pushed a commit that referenced this pull request May 20, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
…ython#133984) Using the if instruction results in slightly shorter trampoline code.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…ython#133984) Using the if instruction results in slightly shorter trampoline code.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…ython#133984) Using the if instruction results in slightly shorter trampoline code.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out about the
ifinstruction which lets us have slightly shorter code here.