bpo-36959: Fix checks for invalid ISO date formats in _strptime#13408
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
GPHemsleyforce-pushed the strptime-iso-errors branch from c3c93e8 to 4e29c31Compare
Carreau approved these changes May 29, 2019
serhiy-storchaka approved these changes Dec 26, 2023
serhiy-storchaka added needs backport to 3.11 
Thanks @GPHemsley for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-113495 is a backport of this pull request to the 3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2023
…ime() (pythonGH-13408) Previously some error messages complained about incompatible combinations of directives that are not contained in the format string. (cherry picked from commit 4b2c3e8) Co-authored-by: Gordon P. Hemsley <me@gphemsley.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sorry, @GPHemsley and @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Dec 26, 2023
… _strptime() (pythonGH-13408) Previously some error messages complained about incompatible combinations of directives that are not contained in the format string. (cherry picked from commit 4b2c3e8) Co-authored-by: Gordon P. Hemsley <me@gphemsley.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-113499 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka added a commit that referenced this pull request Dec 26, 2023
… _strptime() (GH-13408) (GH-113495) Previously some error messages complained about incompatible combinations of directives that are not contained in the format string. (cherry picked from commit 4b2c3e8) Co-authored-by: Gordon P. Hemsley <me@gphemsley.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
…ime() (pythonGH-13408) Previously some error messages complained about incompatible combinations of directives that are not contained in the format string. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ime() (pythonGH-13408) Previously some error messages complained about incompatible combinations of directives that are not contained in the format string. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ime() (pythonGH-13408) Previously some error messages complained about incompatible combinations of directives that are not contained in the format string. Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also simplifies the logic of the leap year check so that
year is Noneis not checked twice.https://bugs.python.org/issue36959