Skip to content

gh-132124: improve safety nets for creating AF_UNIX socket files#134085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpshead merged 4 commits into from
May 21, 2025
Merged

gh-132124: improve safety nets for creating AF_UNIX socket files #134085

gpshead merged 4 commits into from
May 21, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented May 16, 2025•
edited by bedevere-app bot
Loading

@picnixzpicnixz requested a review from gpshead as a code ownerMay 16, 2025 10:49
@bedevere-appbedevere-appbot mentioned this pull request May 16, 2025
Closed
gpshead
gpshead approved these changes May 16, 2025
View reviewed changes
@gpsheadgpshead added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 16, 2025
gpshead
gpshead requested changes May 16, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-appbot commented May 16, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@picnixzpicnixzforce-pushed the fix/multiprocessing/temp-dir-132124 branch from 3233fdc to 84f7020CompareMay 17, 2025 10:18
@picnixz
Copy link
MemberAuthor

picnixz commented May 17, 2025

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-appbot commented May 17, 2025

Thanks for making the requested changes!

@gpshead: please review the changes made to this pull request.

@bedevere-appbedevere-appbot requested a review from gpsheadMay 17, 2025 10:19
@thesamesam
Copy link
Contributor

thesamesam commented May 17, 2025

Thank you! It works (and the change seems to have the semantics I'd expect).

gpshead
gpshead approved these changes May 21, 2025
View reviewed changes
Lib/multiprocessing/util.py

__all__ = [
'sub_debug', 'debug', 'info', 'sub_warning', 'get_logger',
'sub_debug', 'debug', 'info', 'sub_warning', 'warn', 'get_logger',
Copy link
Member

@gpsheadgpsheadMay 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: I'm going to leave 'warn' out of __all__ and rename the function to _warn as a modification to our 3.13 backport as it'd technically be an API change in a bugfix release otherwise.

@gpsheadgpshead merged commit 1a07a01 into python:mainMay 21, 2025
44 of 47 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented May 21, 2025

Thanks @picnixz for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@picnixz@miss-islington
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
036d6a8
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented May 21, 2025

GH-134447 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2025
@picnixz@miss-islington
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
adb75fc
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label May 21, 2025
@bedevere-app
Copy link

bedevere-appbot commented May 21, 2025

GH-134448 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 21, 2025
gpshead pushed a commit that referenced this pull request May 21, 2025
@miss-islington@picnixz
[3.14]gh-132124: improve safety nets for creating AF_UNIX socket fil…
f8ced87
…es (GH-134085) (#134447) gh-132124: improve safety nets for creating AF_UNIX socket files (GH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <[email protected]>
@picnixzpicnixz deleted the fix/multiprocessing/temp-dir-132124 branch May 23, 2025 12:22
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@picnixz@lkollar
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
d0cd049
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@picnixz@Pranjal095
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
a2c5143
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used
gpshead added a commit that referenced this pull request Aug 4, 2025
@miss-islington@picnixz@gpshead
[3.13]gh-132124: improve safety nets for creating AF_UNIX socket fil…
932221b
…es (GH-134085) (#134448) * gh-132124: improve safety nets for creating AF_UNIX socket files (GH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used (cherry picked from commit 1a07a01) Co-authored-by: Bénédikt Tran <[email protected]> * rename warn -> _warn for the 3.13.x backport * Update Misc/NEWS.d/next/Library/2025-05-16-12-40-37.gh-issue-132124.T_5Odx.rst --------- Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz@taegyunkim
pythongh-132124: improve safety nets for creating AF_UNIX socket files (
ed24f71
pythonGH-134085) * ensure that we can create AF_UNIX socket files * emit a warning if system-wide temporary directory is used
zmedico
zmedico reviewed Oct 29, 2025
View reviewed changes
Lib/multiprocessing/util.py
# [2]: https://man7.org/linux/man-pages/man7/unix.7.html.

if sys.platform == 'linux':
_SUN_PATH_MAX = 108
Copy link

@zmedicozmedicoOct 29, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This _SUN_PATH_MAX = 108 value for Linux includes a null terminator, resulting in #140734.

@thesamesamthesamesam mentioned this pull request Oct 29, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

+1 more reviewer

@zmedicozmedicozmedico left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz@thesamesam@gpshead@zmedico