Skip to content

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task#134202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 6 commits into from
May 22, 2025
Merged

gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task #134202

gvanrossum merged 6 commits into from
May 22, 2025

Conversation

@graingert
Copy link
Contributor

@graingertgraingert commented May 19, 2025•
edited by github-actions bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request May 19, 2025
Closed
@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news labels May 19, 2025
graingert
graingert commented May 19, 2025
View reviewed changes
graingert
graingert commented May 19, 2025
View reviewed changes
graingert
graingert commented May 19, 2025
View reviewed changes
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes
@gvanrossumgvanrossum mentioned this pull request May 20, 2025
Merged
@graingertgraingert marked this pull request as ready for review May 20, 2025 06:54
gvanrossum
gvanrossum reviewed May 20, 2025
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I'm uneasy with how name, context and eager_task arguments are presented.

@gvanrossum
Copy link
Member

gvanrossum commented May 20, 2025

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

@graingert
Copy link
ContributorAuthor

graingert commented May 20, 2025•
edited
Loading

You're also going to backport these to 3.13 right? (But describing how 3.13.4 works -- you can't change 3.13.3 by definition).

I thought we were happy with the docs on 3.13 now? So this won't need a backport

@gvanrossum
Copy link
Member

gvanrossum commented May 20, 2025

I thought we were happy with the docs on 3.13 now? So this won't need a backport

Agreed, not to 3.13. But this should be marked as backport to 3.14 right?

What do you think about my comment on the signature description?

@gvanrossumgvanrossum added the needs backport to 3.14 bugs and security fixes label May 20, 2025
gvanrossum
gvanrossum approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG then! I will merge and ensure a backport to 3.14 happens.

@gvanrossumgvanrossum changed the title gh-128307: update docs to TaskGroup.create_task and asyncio.create_taskgh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_taskMay 22, 2025
@gvanrossumgvanrossum merged commit a3d0306 into python:mainMay 22, 2025
32 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsMay 22, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented May 22, 2025

Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2025
@graingert@miss-islington
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
cd5c579
…e_task, asyncio.create_task (pythonGH-134202) (cherry picked from commit a3d0306) Co-authored-by: Thomas Grainger <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented May 22, 2025

GH-134553 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label May 22, 2025
kumaraditya303 pushed a commit that referenced this pull request May 23, 2025
@miss-islington@graingert
[3.14]gh-128307: Update docs for asyncio.create_task, TaskGroup.crea…
1cdbb33
…te_task, asyncio.create_task (GH-134202) (#134553) gh-128307: Update docs for asyncio.create_task, TaskGroup.create_task, asyncio.create_task (GH-134202) (cherry picked from commit a3d0306) Co-authored-by: Thomas Grainger <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@graingert@Pranjal095
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
2cfbdab
…e_task, asyncio.create_task (python#134202)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@graingert@taegyunkim
pythongh-128307: Update docs for asyncio.create_task, TaskGroup.creat…
c2dab71
…e_task, asyncio.create_task (python#134202)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@graingert@gvanrossum@kumaraditya303