Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-131178: fix SSL tests for http.server command-line interface#134224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Semyon Moroz <donbarbos@proton.me>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz commented May 19, 2025
!buildbot ASAN |
bedevere-bot commented May 19, 2025
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 0e0fb7a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134224%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
picnixz commented May 19, 2025
!buildbot x86-64 MacOS Intel ASAN NoGIL PR |
bedevere-bot commented May 19, 2025
🤖 New build scheduled with the buildbot fleet by @picnixz for commit e818bb6 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134224%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
picnixz commented May 19, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
So the failures are the following: We fixed the AttributeError, but I don't know why the other happens. |
picnixz commented May 19, 2025
Note: using localhost instead of 127.0.0.1 doesn't seem the right solution as we also have tests with 127.0.0.1 elsewhere. However, maybe we can just ignore the bind itself and check for the "best" address (which is chosen by |
picnixz commented May 19, 2025
I've committed directly to your branch as the tier-1 bot is failing (making it hard to fix another issue I introduced in a subsequent commit, not your fault!) |
picnixz commented May 19, 2025
!buildbot x86-64 MacOS Intel ASAN NoGIL PR |
bedevere-bot commented May 19, 2025
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 9192281 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134224%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
picnixz commented May 19, 2025
Ok, so the tests now hang on non-Linux bots. I'll stop working on this branch and will come back on my linux in a few hours. |
picnixz left a comment • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So localhost doesn't work and 127.0.0.1 doesn't work for some build bots. I think we'll just leave it to the script the responsibility to start the server and we'll deduce the bind address from the output.
picnixz commented May 19, 2025
Ok, so now, the tests entirely hang for some obscure reasons. I'll open a new PR instead, sorry for messing up your branch though (but thank you for your quick response time). |
picnixz commented May 19, 2025
I've opened #134279 |
Uh oh!
There was an error while loading. Please reload this page.