gh-125843: fix test_curses.test_attributes on x86-64 macOS#134252
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
picnixz changed the title test_curses.test_attributes on x86-64 macOS This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
MemberAuthor
picnixz commented May 19, 2025
!buildbot x86-64 MacOS Intel |
bedevere-bot commented May 19, 2025
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 8fcdb53 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134252%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
picnixz added the 🔨 test-with-buildbots 
bedevere-bot removed the 🔨 test-with-buildbots picnixz added the 🔨 test-with-buildbots bedevere-bot removed the 🔨 test-with-buildbots 
picnixz added the 🔨 test-with-buildbots bedevere-bot commented May 19, 2025
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 8004b3d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134252%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
picnixz commented May 19, 2025
Uh oh!
There was an error while loading. Please reload this page.
picnixz merged commit e007e62 into python:main 38 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Member
encukou commented May 20, 2025
Thank you for the fix! |
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…ython#134252) While some `libcurses` functions are meant to return OK on success, this is not always the case for all implementations. As such, we relax the checks on the return values and allow any non-ERR value to be considered equivalent to OK.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…ython#134252) While some `libcurses` functions are meant to return OK on success, this is not always the case for all implementations. As such, we relax the checks on the return values and allow any non-ERR value to be considered equivalent to OK.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, on x86-64 MacOS Intel with and without GIL,
test_curses.test_attributesfailed, but I don't really know why after looking at the code. So, I'll just check by hand to check what kind of error is actually being returned.cursesby indicating failed C function #125843