gh-134261: ZipFile - Don't rely on local time for reproducible builds & tests#134264
+8 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
All commit authors signed the Contributor License Agreement. |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Contributor
Wulian233 commented May 20, 2025
I added this feature 8 months ago. There was a reason for using localtime. See #124435 (review) and 54a7116 Maybe we can ask @jaraco |
| @@ -0,0 +1 @@ | |||
| zip: On reproducible builds, ZipFile longer pulls in local environment timezone when writing file datetimes | |||
Member
There was a problem hiding this comment.
Suggested change
| zip: On reproducible builds, ZipFile longer pulls in local environment timezone when writing file datetimes | |
| zip: On reproducible builds, ZipFile uses UTC instead of the local time when writing file datetimes to avoid underflows. |
Member
emmatyping commented Jul 23, 2025
@jaraco would you have time to look at this one? Would appreciate your expertise on whether changing to UTC time would be acceptable only for cases where |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #134261 for issue background and technical detail on causes. This solves the issue by using
gmtimewheneverSOURCE_DATE_EPOCHis involved, to prevent pulling in system timezone information when performing time calculations.