Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-114177: avoid calling connection lost callbacks when loop is already closed in asyncio subprocess#134508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
kumaraditya303 commented May 22, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, one nit.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
5804ee7 into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
… already closed in asyncio subprocess (pythonGH-134508) (cherry picked from commit 5804ee7) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
… already closed in asyncio subprocess (pythonGH-134508) (cherry picked from commit 5804ee7) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
GH-134561 is a backport of this pull request to the 3.14 branch. |
GH-134562 is a backport of this pull request to the 3.13 branch. |
bedevere-bot commented May 23, 2025
|
… already closed in asyncio subprocess (python#134508)
… already closed in asyncio subprocess (python#134508)
When the event loop is already closed, skip calling closing the pipe as it would otherwise lead to calling
connection_lostcallbacks which would error out of loop being closed.See issue for detailed analysis.
BaseSubprocessTransport.__del__fails if the event loop is already closed, which can leak an orphan process #114177