GH-130328: Fix WindowsConsoleGetEventTests after gh-133728#134660
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ambv changed the title 
Contributor
ambv commented May 25, 2025
!buildbot Windows10 |
bedevere-bot commented May 25, 2025
🤖 New build scheduled with the buildbot fleet by @ambv for commit 7f15126 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134660%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Contributor
ambv commented May 25, 2025
Buildbot looks happy now! |
ambv merged commit 1000283 into python:main 49 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @chris-eibl for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2025
pythongh-134660) (cherry picked from commit 1000283) Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
GH-134666 is a backport of this pull request to the 3.14 branch. |
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the WindowsConsoleGetEventTests which got broken due to moving
waitintoget_eventinWindowsConsoleduring #133728.