Skip to content

gh-134160: Block multiple module initialization#134773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AA-Turner merged 4 commits into from
May 28, 2025
Merged

gh-134160: Block multiple module initialization #134773

AA-Turner merged 4 commits into from
May 28, 2025

Conversation

@encukou
Copy link
Member

@encukouencukou commented May 27, 2025•
edited by github-actions bot
Loading

Change the tutorial to block multiple module initialization, and note the reference leak.

📚 Documentation preview 📚: https://cpython-previews--134773.org.readthedocs.build/

@bedevere-appbedevere-appbot mentioned this pull request May 27, 2025
Open
@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news labels May 27, 2025
@encukou
Copy link
MemberAuthor

encukou commented May 27, 2025

There's a better way to do this, but module state might work better in Chapter 2?

neonene
neonene reviewed May 27, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed May 27, 2025
View reviewed changes
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that we don't have any dedicated section on subinterpreters. I'd be happy to do that in a follow-up.

StanFromIreland
StanFromIreland reviewed May 27, 2025
View reviewed changes
encukouand others added 2 commits May 27, 2025 17:38
AA-Turner
AA-Turner reviewed May 27, 2025
View reviewed changes
AA-Turner
AA-Turner reviewed May 27, 2025
View reviewed changes
AA-Turner
AA-Turner approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@AA-TurnerAA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor suggestions, but otherwise let's get this merged quickly.

A

@AA-TurnerAA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 27, 2025
@encukou@AA-Turner
Apply suggestions from code review
c562e2e
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-TurnerAA-Turner merged commit 469a564 into python:mainMay 28, 2025
24 checks passed
@github-project-automationgithub-project-automationbot moved this from Todo to Done in Docs PRsMay 28, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented May 28, 2025

Thanks @encukou for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@encukou@AA-Turner@miss-islington
pythongh-134160: Block multiple module initialization (pythonGH-134773)
bd36c93
(cherry picked from commit 469a564) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2025
@encukou@AA-Turner@miss-islington
pythongh-134160: Block multiple module initialization (pythonGH-134773)
6d5c370
(cherry picked from commit 469a564) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-appbot commented May 28, 2025

GH-134827 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label May 28, 2025
@bedevere-app
Copy link

bedevere-appbot commented May 28, 2025

GH-134828 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label May 28, 2025
@encukouencukou deleted the extending-exec-once branch May 28, 2025 07:56
AA-Turner added a commit that referenced this pull request May 28, 2025
@miss-islington@encukou@AA-Turner
[3.14]gh-134160: Block multiple module initialization (GH-134773) (#…
998cedb
…134827) gh-134160: Block multiple module initialization (GH-134773) (cherry picked from commit 469a564) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner added a commit that referenced this pull request May 28, 2025
@miss-islington@encukou@AA-Turner
[3.13]gh-134160: Block multiple module initialization (GH-134773) (#…
067df2b
…134828) gh-134160: Block multiple module initialization (GH-134773) (cherry picked from commit 469a564) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou@AA-Turner@Pranjal095
pythongh-134160: Block multiple module initialization (python#134773)
6adbe96
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou@AA-Turner@taegyunkim
pythongh-134160: Block multiple module initialization (python#134773)
e8d345a
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@AA-TurnerAA-TurnerAA-Turner approved these changes

+1 more reviewer

@neoneneneoneneneonene left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@encukou@AA-Turner@ZeroIntensity@neonene@StanFromIreland