gh-134248 test_getallocatedblocks pre-check to ignore immortalized strings#134871
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…zed strings When sanity checking against gettotalrefcount we exclude the blocks for immortalized strings since their references are not tracked/reported. This now matches refleak.py's book-keeping using the same functions.
All commit authors signed the Contributor License Agreement. |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
vstinner approved these changes Jun 3, 2025
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM. It makes sense to use sys.getunicodeinternedsize() here.
vstinner merged commit 54ca559 into python:main 48 checks passed
Uh oh!
There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2025
…zed strings (pythonGH-134871) When sanity checking against gettotalrefcount(), we exclude the blocks for immortalized strings since their references are not tracked/reported. This now matches refleak.py's book-keeping using the same functions. (cherry picked from commit 54ca559) Co-authored-by: tpburns <[email protected]>
GH-135095 is a backport of this pull request to the 3.14 branch. |
Member
vstinner commented Jun 3, 2025
Merged, thank you. |
vstinner pushed a commit that referenced this pull request Jun 3, 2025
…ized strings (GH-134871) (#135095) gh-134248 test_getallocatedblocks pre-check to ignore immortalized strings (GH-134871) When sanity checking against gettotalrefcount(), we exclude the blocks for immortalized strings since their references are not tracked/reported. This now matches refleak.py's book-keeping using the same functions. (cherry picked from commit 54ca559) Co-authored-by: tpburns <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…zed strings (python#134871) When sanity checking against gettotalrefcount(), we exclude the blocks for immortalized strings since their references are not tracked/reported. This now matches refleak.py's book-keeping using the same functions.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…zed strings (python#134871) When sanity checking against gettotalrefcount(), we exclude the blocks for immortalized strings since their references are not tracked/reported. This now matches refleak.py's book-keeping using the same functions.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…zed strings (python#134871) When sanity checking against gettotalrefcount(), we exclude the blocks for immortalized strings since their references are not tracked/reported. This now matches refleak.py's book-keeping using the same functions.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sanity checking against
gettotalrefcountwe exclude the blocks for immortalized strings since their references are not tracked/reported. This now matchesrefleak.py'sbook-keeping using the same functions.--disable-gilbuilds #115999.test_sys.SysModuleTest.get_allocated_blockstest precondition intermittently fails on iOS #130384, I would appreciate guidance on how testing that would work.As such, the current state of the PR is that the check is never skipped - to be be adjusted as needed given CI results and/or feedback.