gh-135001: Explicitly specify the encoding parameter value of `calendar.HTMLCalendar` as 'utf-8'#135002

Wulian233 · 2025-06-01T11:47:35Z

Issue: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' #135001

📚 Documentation preview 📚: https://cpython-previews--135002.org.readthedocs.build/

Lib/calendar.py

Doc/whatsnew/3.15.rst

picnixz · 2025-06-01T12:08:00Z

Making it a draft as it's a WIP.

Lib/test/test_calendar.py

Lib/calendar.py

bedevere-app · 2025-06-02T08:01:03Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Wulian233 · 2025-06-02T08:38:20Z

The new commit resolves the above review and requires you to confirm that it is resolved. Thanks!

I have made the requested changes; please review again

bedevere-app · 2025-06-02T08:38:24Z

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

Doc/library/calendar.rst

Doc/whatsnew/3.15.rst

Lib/calendar.py

Misc/NEWS.d/next/Library/2025-06-01-19-45-55.gh-issue-135001.KsBXSl.rst

.

vstinner

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

Lib/test/test_calendar.py

Wulian233 · 2025-06-06T01:42:48Z

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

I just using git reset was not the right thing to do, and I apologize for that. I honestly didn’t consider this at the time

I’ve added a news entry, do you think that’s necessary?

vstinner · 2025-06-06T07:45:20Z

I’ve added a news entry, do you think that’s necessary?

I don't think that it's necessary.

…otIVz.rst

vstinner

LGTM

vstinner · 2025-06-09T13:00:22Z

test_syntax was failing on the CI. I updated the branch to try to repair the CI.

vstinner · 2025-06-09T13:40:44Z

Merged, thanks.

…calendar.HTMLCalendar` as 'utf-8' (python#135002)

Change the default *encoding* of calendar.HTMLCalendar to UTF-8
68bd800

bedevere-appbot added the awaiting review label Jun 1, 2025

bedevere-appbot mentioned this pull request Jun 1, 2025
Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' #135001
Closed

Wulian233 changed the title ~~gh-135001: Change the default parameter value of calendar.HTMLCalendar to utf-8~~gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8Jun 1, 2025

picnixz reviewed Jun 1, 2025
View reviewed changes

Lib/calendar.pyShow resolvedHide resolved
Doc/whatsnew/3.15.rst Outdated Show resolvedHide resolved

picnixz marked this pull request as draft June 1, 2025 12:07

bedevere-appbot removed the awaiting review label Jun 1, 2025

Wulian233 marked this pull request as ready for review June 1, 2025 13:00

bedevere-appbot added the awaiting review label Jun 1, 2025

Wulian233 requested a review from picnixz June 1, 2025 13:39

picnixz previously requested changes Jun 2, 2025
View reviewed changes

Lib/test/test_calendar.pyShow resolvedHide resolved
Lib/calendar.pyShow resolvedHide resolved

bedevere-appbot added awaiting changes and removed awaiting review labels Jun 2, 2025

bedevere-appbot added awaiting change review and removed awaiting changes labels Jun 2, 2025

bedevere-appbot requested a review from picnixz June 2, 2025 08:38

picnixz reviewed Jun 2, 2025
View reviewed changes

bedevere-appbot added awaiting review and removed awaiting change review labels Jun 2, 2025

vstinner reviewed Jun 5, 2025
View reviewed changes

Lib/test/test_calendar.pyShow resolvedHide resolved

Wulian233 force-pushed the calendar branch from d37c9cc to 68bd800Compare June 6, 2025 01:12

fix
a232d70

Wulian233 changed the title ~~gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8~~gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8'Jun 6, 2025

fix
a0465f3

lint
f5da0b9

Merge branch 'main' into calendar
dd69284

Wulian233 mentioned this pull request Jun 6, 2025
gh-134036: Improve error messages for invalid raise statements #134077
Merged

Delete Misc/NEWS.d/next/Library/2025-06-06-09-20-46.gh-issue-135001.z…
bf55ca4
…otIVz.rst

vstinner approved these changes Jun 9, 2025
View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels Jun 9, 2025

Merge branch 'main' into calendar
5618fa0

vstinner added the skip news label Jun 9, 2025

vstinner merged commit f90483e into python:mainJun 9, 2025
41 checks passed

bedevere-appbot removed the awaiting merge label Jun 9, 2025

Wulian233 deleted the calendar branch June 9, 2025 13:51

lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
pythongh-135001: Explicitly specify the encoding parameter value of `…
1b2c7a3
…calendar.HTMLCalendar` as 'utf-8' (python#135002)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-135001: Explicitly specify the encoding parameter value of `…
40e6367
…calendar.HTMLCalendar` as 'utf-8' (python#135002)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-135001: Explicitly specify the encoding parameter value of `…
246473b
…calendar.HTMLCalendar` as 'utf-8' (python#135002)

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-135001: Explicitly specify the encoding parameter value of `…
f5f6eef
…calendar.HTMLCalendar` as 'utf-8' (python#135002)

Uh oh!

gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8'#135002

gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' #135002

Uh oh!

Conversation

Wulian233 commented Jun 1, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz commented Jun 1, 2025

Uh oh!

Uh oh!

Uh oh!

bedevere-appbot commented Jun 2, 2025

Uh oh!

Wulian233 commented Jun 2, 2025

Uh oh!

bedevere-appbot commented Jun 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Wulian233 commented Jun 6, 2025

Uh oh!

vstinner commented Jun 6, 2025

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented Jun 9, 2025

Uh oh!

Uh oh!

vstinner commented Jun 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-135001: Explicitly specify the encoding parameter value of `calendar.HTMLCalendar` as 'utf-8'#135002

gh-135001: Explicitly specify the encoding parameter value of `calendar.HTMLCalendar` as 'utf-8' #135002

Wulian233 commented Jun 1, 2025•
edited
Loading