gh-131798: JIT: Optimize _CALL_TYPE_1 when the result is known#135194
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fidget-Spinner approved these changes Jun 6, 2025
MemberAuthor
tomasr8 commented Jun 6, 2025
The test failures should be fixed by #135204, let me update main to make sure CI is all green :) |
brandtbucher approved these changes Jun 6, 2025
Member
brandtbucher left a comment
brandtbucher left a comment There was a problem hiding this comment.
Even more JIT magic, I love it.
| self.assertEqual(res, TIER2_THRESHOLD) | ||
| self.assertIsNotNone(ex) | ||
| uops=get_opnames(ex) | ||
| self.assertIn("_CALL_TYPE_1", uops) |
Member
There was a problem hiding this comment.
Super cool when older tests like this "break" with a new optimization. :)
brandtbucher merged commit 4615164 into python:main 54 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #134369 (comment)
This completely removes
_CALL_TYPE_1when the abstract interpreter is able to deduce the result (by knowing the type of the argument).For example, for something like
type(42), we currently doNote that we still do the call even when we know the result.
In this PR, when the result is known,
_CALL_TYPE_1is replaced with_POP_CALL_ONE_LOAD_CONST_INLINE_BORROW:Thanks to some previous work on optimizing
remove_unneeded_uopsthis becomes just:that is, the entire call is replaced with a load.