bpo-36876: Use a consistent variable name for kwlist.#13531
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ericsnowcurrently requested review from berkerpeksag and rhettinger as code owners
Member
vstinner commented May 24, 2019
I'm not super excited by PR only changing the coding style. Can't you use a tool which understand that the static is a constant and it's value is constant? |
MemberAuthor
ericsnowcurrently commented May 29, 2019
You're right. :) |
Member
vstinner commented May 29, 2019
Sorry :-( |
Open
17 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a consistent variable name helps simplify efforts to identify C globals that need to be moved. (A consistent name is easier to ignore.)
https://bugs.python.org/issue36876