gh-131876: extract _hashlib helpers into a separate directory [WIP]#135341
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
picnixz commented Jun 10, 2025
!buildbot FIPS only |
bedevere-bot commented Jun 10, 2025
🤖 New build scheduled with the buildbot fleet by @picnixz for commit c90722e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135341%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch from cb8ac17 to b213a79CompareMemberAuthor
picnixz commented Jun 10, 2025
Ok. This is too messy. I'll need to think about it differently. |
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch 6 times, most recently from 11b0d3c to 0692cccCompareMemberAuthor
Ok, for now it seems to work on Linux/macOS. Still need to figure out why it fails on WASI and Windows but I have my little idea. |
picnixz commented Jun 10, 2025
Uh oh!
There was an error while loading. Please reload this page.
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch 2 times, most recently from 28067ff to 5f21471Comparepicnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch from 5f21471 to e705d15Comparepicnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch 2 times, most recently from 1cb7edb to 3dd0a97CompareMemberAuthor
picnixz commented Jun 14, 2025
Ok WASI moments. But Windows works! |
picnixzforce-pushed the refactor/hashlib/lookup-md-131876 branch from 1eeae0a to 972a185CompareMemberAuthor
picnixz commented Jul 22, 2025
I'm done with my experiments, I'll create a fresh PR to have better commits. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_hashliband_hmac#131876