gh-119180: Only fetch globals and locals if necessary in annotationlib.get_annotations()#135644
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ationlib.get_annotations()`
30 tasks
JelleZijlstra approved these changes Jun 18, 2025
JelleZijlstra merged commit 504ae60 into python:main 49 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @Viicos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
…ationlib.get_annotations()` (pythonGH-135644) (cherry picked from commit 504ae60) Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
GH-135654 is a backport of this pull request to the 3.14 branch. |
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
…ationlib.get_annotations()` (python#135644)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
…ationlib.get_annotations()` (python#135644)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
…ationlib.get_annotations()` (python#135644)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
…ationlib.get_annotations()` (python#135644)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposed small optimization. Best reviewed without whitespace: https://github.com/python/cpython/pull/135644/files?diff=split&w=1.