Skip to content

gh-134584: Specialize POP_TOP by reference and type in JIT#135761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 9 commits into from
Jun 23, 2025
Merged

gh-134584: Specialize POP_TOP by reference and type in JIT #135761

Fidget-Spinner merged 9 commits into from
Jun 23, 2025

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-SpinnerFidget-Spinner commented Jun 20, 2025•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jun 20, 2025
Closed
35 tasks
markshannon
markshannon reviewed Jun 20, 2025
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

You can streamline the optimization a bit using sym_is_immortal and you might want to add a test for optimizing the POP_TOP after a call that returns None.

markshannon
markshannon reviewed Jun 20, 2025
View reviewed changes
Fidget-Spinner
Fidget-Spinner commented Jun 20, 2025
View reviewed changes
Python/optimizer_bytecodes.c
JitOptRef temp = retval;
// We wrap and unwrap the value to mimic PyStackRef_MakeHeapSafe
// in bytecodes.c
JitOptRef temp = PyJitRef_Wrap(PyJitRef_Unwrap(retval));
Copy link
MemberAuthor

@Fidget-SpinnerFidget-SpinnerJun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bug in the previous implementation. This was only exposed in this PR.

Fidget-Spinner
Fidget-Spinner commented Jun 22, 2025
View reviewed changes
Python/optimizer_symbols.c
if (sym->tag == JIT_SYM_KNOWN_CLASS_TAG){
return sym->cls.type == &PyBool_Type;
}
if (sym->tag == JIT_SYM_TRUTHINESS_TAG){
Copy link
MemberAuthor

@Fidget-SpinnerFidget-SpinnerJun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A truthiness is not immortal. This is a false asumption.

@corona10corona10 mentioned this pull request Jun 22, 2025
Closed
@tomasr8tomasr8 mentioned this pull request Jun 22, 2025
Merged
markshannon
markshannon approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This should wait for TOS caching, otherwise it is adding overhead to STORE_FAST. But once that is in, this makes a nice improvement.

@Fidget-SpinnerFidget-Spinner changed the title gh-134584: Specialize STORE_FAST by reference and type in JITgh-134584: Specialize POP_TOP by reference and type in JITJun 23, 2025
@Fidget-SpinnerFidget-Spinner merged commit 569fc68 into python:mainJun 23, 2025
69 checks passed
@Fidget-SpinnerFidget-Spinner deleted the eliminate_store_fast_refcount branch June 23, 2025 16:57
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@Fidget-Spinner@AndPuQing
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
a126c1a
…honGH-135761)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Fidget-Spinner@Pranjal095
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
2065428
…honGH-135761)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Fidget-Spinner@taegyunkim
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
e635044
…honGH-135761)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Fidget-Spinner@Agent-Hellboy
pythongh-134584: Specialize POP_TOP by reference and type in JIT (pyt…
dae1d14
…honGH-135761)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianschubertbrianschubertbrianschubert left review comments

@markshannonmarkshannonmarkshannon approved these changes

@tomasr8tomasr8Awaiting requested review from tomasr8tomasr8 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fidget-Spinner@markshannon@brianschubert