gh-136097: Fix sysconfig._parse_makefile()#136166
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
serhiy-storchaka added needs backport to 3.13 
serhiy-storchaka removed needs backport to 3.13 
* Fix potential infinite recursion. * Fix a bug when reference can cross boundaries of substitutions, e.g. a=$( b=$(a)a) * Fix potential quadratic complexity. * Fix KeyError for undefined CFLAGS, LDFLAGS, or CPPFLAGS. * Fix infinite recursion when keep_unresolved=False. * Unify behavior with keep_unresolved=False for bogus $ occurred before and after variable references.
serhiy-storchakaforce-pushed the sysconfig-parse_makefile branch from 967214c to 3888755Compare
vstinner approved these changes Jul 2, 2025
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM. Thanks for adding many tests.
FFY00 approved these changes Oct 4, 2025
Member
FFY00 left a comment
FFY00 left a comment There was a problem hiding this comment.
I'm always a bit relunctant to touch this code, but this change looks good. Let's merge and keep an eye out for possible downstream issues 😅
FFY00 merged commit 9e3542a into python:main 44 checks passed
Uh oh!
There was an error while loading. Please reload this page.
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
* Fix potential infinite recursion. * Fix a bug when reference can cross boundaries of substitutions, e.g. a=$( b=$(a)a) * Fix potential quadratic complexity. * Fix KeyError for undefined CFLAGS, LDFLAGS, or CPPFLAGS. * Fix infinite recursion when keep_unresolved=False. * Unify behavior with keep_unresolved=False for bogus $ occurred before and after variable references.
This was referenced Oct 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysconfig --generate-posix-varscan hang on cyclic variable definitions #136097