Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-109700: fix interp finalization while handling memory error#136342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
kumaraditya303 commented Jul 6, 2025
!buildbot refleak* |
bedevere-bot commented Jul 6, 2025
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit ba1e603 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136342%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in principle. I afraid that calling Py_EndInterpreter() can introduce other crashes, because more clean up code can now be executed for not yet initialized parts. There are two ways to solve this:
- Make
Py_EndInterpreter()super robust. - Only call these clean up procedures which are necessary after each error.
In any way, it would be better to fix all potential crashes in one go. But if you prefer, you can merge this PR.
kumaraditya303 commented Jul 7, 2025
I would prefer to do that, it is better for user code too as it is public API but can be done after this. |
0c3e3da into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…rror (pythonGH-136342) (cherry picked from commit 0c3e3da) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
…rror (pythonGH-136342) (cherry picked from commit 0c3e3da) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
GH-136352 is a backport of this pull request to the 3.14 branch. |
GH-136353 is a backport of this pull request to the 3.13 branch. |
Uh oh!
There was an error while loading. Please reload this page.