Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-98388: add tests for happy eyeballs #136368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
kumaraditya303 commented Jul 7, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
LamentXU123 left a comment • edited by gvanrossum
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by gvanrossum
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the PEP 8, style guide, we limit all lines to a maximum of 79 characters.
(EDIT: Removed loud and redundant screenshot image.)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum commented Jul 7, 2025
Let's not do that here. The style guide is voluntary, not mandatory, and in particular the suggested line length limit is often ignored in favor of clarity and/or consistency. |
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's ignore the suggestion of breaking long-ish lines.
0240ef4 into python:mainUh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Jul 7, 2025
|
This adds tests from #98389 with merge conflicts fixed and applied suggestions. I have not added staggered tests as new staggered tests already exists.
Closes#98388
Co-Authored-By: twisteroid ambassador [email protected]