gh-136297: Fix `hypothesis` and `subTest` usage in `test_zoneinfo_property.py`#136384

sobolevn · 2025-07-07T14:23:09Z

CC @kulikjak

Issue: test_zoneinfo_property.py misses tests with all pickle protocols #136297

…fo_property.py`

sobolevn · 2025-07-07T14:55:31Z

It is interesting why CI for #136298 passed. We explicitly have Hypothesis job. Why it didn't fail?

CC @vstinner and @serhiy-storchaka

kulikjak · 2025-07-07T14:57:07Z

Thanks! I tested the patch and the test passes now.

serhiy-storchaka

Can this depend on the hypothesis version?

sobolevn · 2025-07-07T15:12:57Z

@kulikjak what version do you use?
We have hypothesis==6.111.2 on main, I also tried 6.135.26 and it worked locally with both subTest and without it.

kulikjak · 2025-07-07T16:18:33Z

Oh, that might be the issue. I have 6.100.1 installed - I will test it with the latest one.

kulikjak · 2025-07-07T17:17:16Z

I just tried it with 6.111.2 and 6.135.26 and the subTest is still failing :(.

I checked the hypothesis sources and this warning/error was added with HypothesisWorks/hypothesis#1072 and is still there. And the comment there indeed suggest that @given and subTest do not work nicely together.

sobolevn · 2025-07-07T17:25:01Z

Aha! Adding -We indeed helps to fail the test case! I will try adding -We to the job.

sobolevn · 2025-07-07T17:26:43Z

I added -We as an experiment. I also kept subTest in one place. Now CI must fail.

kulikjak

Thanks! I retested the changes and the test passes.

serhiy-storchaka · 2025-07-08T06:43:30Z

.github/workflows/build.yml

 # (GH-104097) test_sysconfig is skipped because it has tests that are
 # failing when executed from inside a virtual environment.
- "${VENV_PYTHON}" -m test \
+ "${VENV_PYTHON}" -We -m test \


This is not related change. It is better to do it separately, and first examine the history, because it can break tests.

Ok, I will open a new issue about it.

Done #136409

sobolevn · 2025-07-08T07:28:31Z

Thanks everyone!

miss-islington-app · 2025-07-08T07:51:41Z

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

…fo_property.py` (pythonGH-136384) (cherry picked from commit db699db) Co-authored-by: sobolevn <[email protected]>

bedevere-app · 2025-07-08T07:51:49Z

GH-136407 is a backport of this pull request to the 3.14 branch.

…fo_property.py` (pythonGH-136384) (cherry picked from commit db699db) Co-authored-by: sobolevn <[email protected]>

bedevere-app · 2025-07-08T07:51:57Z

GH-136408 is a backport of this pull request to the 3.13 branch.

…nfo_property.py` (GH-136384) (#136408) gh-136297: Fix `hypothesis` and `subTest` usage in `test_zoneinfo_property.py` (GH-136384) (cherry picked from commit db699db) Co-authored-by: sobolevn <[email protected]>

kulikjak · 2025-07-08T08:14:53Z

Thanks for the fix!

…nfo_property.py` (GH-136384) (#136407) gh-136297: Fix `hypothesis` and `subTest` usage in `test_zoneinfo_property.py` (GH-136384) (cherry picked from commit db699db) Co-authored-by: sobolevn <[email protected]>

…fo_property.py` (python#136384)

pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
a620cbb
…fo_property.py`

bedevere-appbot added the awaiting core review label Jul 7, 2025

bedevere-appbot mentioned this pull request Jul 7, 2025
test_zoneinfo_property.py misses tests with all pickle protocols #136297
Closed

bedevere-appbot added the tests Tests in the Lib/test dir label Jul 7, 2025

sobolevn added the skip news label Jul 7, 2025

kulikjak approved these changes Jul 7, 2025
View reviewed changes

serhiy-storchaka approved these changes Jul 7, 2025
View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels Jul 7, 2025

CI must fail now
e4cb74c

sobolevn requested review from AA-Turner, ezio-melotti and hugovk as code owners July 7, 2025 17:26

sobolevn added 2 commits July 7, 2025 20:37

CI must fail now
514bba0

Remove subTest again
cec90db

sobolevn requested review from kulikjak and serhiy-storchaka July 7, 2025 19:01

kulikjak approved these changes Jul 8, 2025
View reviewed changes

serhiy-storchaka reviewed Jul 8, 2025
View reviewed changes

Address review
cda40c4

serhiy-storchaka approved these changes Jul 8, 2025
View reviewed changes

sobolevn enabled auto-merge (squash) July 8, 2025 07:28

sobolevn added the needs backport to 3.13 bugs and security fixes label Jul 8, 2025

sobolevn added the needs backport to 3.14 bugs and security fixes label Jul 8, 2025

sobolevn merged commit db699db into python:mainJul 8, 2025
43 checks passed

bedevere-appbot removed the awaiting merge label Jul 8, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 8, 2025
pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
e424a53
…fo_property.py` (pythonGH-136384) (cherry picked from commit db699db) Co-authored-by: sobolevn <[email protected]>

bedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Jul 8, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 8, 2025
pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
12f1172
…fo_property.py` (pythonGH-136384) (cherry picked from commit db699db) Co-authored-by: sobolevn <[email protected]>

bedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jul 8, 2025

sobolevn mentioned this pull request Jul 8, 2025
Consider running Hypothesis tests with -We#136409
Open

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
1b348c2
…fo_property.py` (python#136384)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
67149e5
…fo_property.py` (python#136384)

picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
6f403d1
…fo_property.py` (python#136384)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
f465398
…fo_property.py` (python#136384)

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythongh-136297: FixhypothesisandsubTestusage in `test_zonein…
a50602f
…fo_property.py` (python#136384)

Uh oh!

gh-136297: Fix hypothesis and subTest usage in test_zoneinfo_property.py#136384

gh-136297: Fix hypothesis and subTest usage in test_zoneinfo_property.py#136384

Uh oh!

Conversation

sobolevn commented Jul 7, 2025• edited by bedevere-app botLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn commented Jul 7, 2025

Uh oh!

kulikjak commented Jul 7, 2025

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

sobolevn commented Jul 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kulikjak commented Jul 7, 2025

Uh oh!

kulikjak commented Jul 7, 2025

Uh oh!

sobolevn commented Jul 7, 2025

Uh oh!

sobolevn commented Jul 7, 2025

Uh oh!

kulikjak left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaJul 8, 2025

Choose a reason for hiding this comment

Uh oh!

sobolevnJul 8, 2025

Choose a reason for hiding this comment

Uh oh!

sobolevnJul 8, 2025

Choose a reason for hiding this comment

Uh oh!

sobolevn commented Jul 8, 2025

Uh oh!

Uh oh!

miss-islington-appbot commented Jul 8, 2025

Uh oh!

bedevere-appbot commented Jul 8, 2025

Uh oh!

bedevere-appbot commented Jul 8, 2025

Uh oh!

kulikjak commented Jul 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gh-136297: Fix `hypothesis` and `subTest` usage in `test_zoneinfo_property.py`#136384

gh-136297: Fix `hypothesis` and `subTest` usage in `test_zoneinfo_property.py`#136384

sobolevn commented Jul 7, 2025•
edited by bedevere-app bot
Loading

sobolevn commented Jul 7, 2025•
edited
Loading