gh-132661: Add default value (of "") for Interpolation.expression#136441
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
lysnikolaou left a comment
lysnikolaou left a comment There was a problem hiding this comment.
Let's add a test that checks that instantiating an Interpolation without an expression actually populates expression with the empty string and it's good to go!
ContributorAuthor
Sure; done! |
lysnikolaou merged commit f1b8d01 into python:main 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @davepeck for the PR, and @lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2025
…ssion` (pythonGH-136441) (cherry picked from commit f1b8d01) Co-authored-by: Dave Peck <davepeck@gmail.com>
GH-136511 is a backport of this pull request to the 3.14 branch. |
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…n.expression` (pythonGH-136441) (python#136511) Co-authored-by: Dave Peck <davepeck@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per pending updates to PEP 750, we now provide an empty string default for
Interpolation.expression.If you're using t-string literals,
Interpolation.expressionis set to the original source text. But if you're writing code that createsInterpolationinstances directly, there isn't always an obvious choice forexpression.