gh-116738: Make pwd module thread-safe#136695
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
yoney commented Jul 15, 2025
Note: I am not sure if there is a CI setup where |
mpage approved these changes Jul 16, 2025
Contributor
mpage left a comment
mpage left a comment There was a problem hiding this comment.
Looks great! I'll wait to merge for a day or two to give other folks a chance to look.
colesbury approved these changes Jul 16, 2025
kumaraditya303 approved these changes Jul 17, 2025
mpage merged commit eddc8c0 into python:main 49 checks passed
Uh oh!
There was an error while loading. Please reload this page.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Make the pwd module functions getpwuid(), getpwnam(), and getpwall() thread-safe. These changes apply to scenarios where the GIL is disabled or in subinterpreter use cases.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
Make the pwd module functions getpwuid(), getpwnam(), and getpwall() thread-safe. These changes apply to scenarios where the GIL is disabled or in subinterpreter use cases.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
pwdmodule functionsgetpwuid(),getpwnam(), andgetpwall()thread-safe. These changes apply to scenarios where the GIL is disabled or in subinterpreter use cases.Py_LIMITED_APIto usePyMutex, necessary for both FT-Python and subinterpreter use cases, similar to changes in the grp module (gh-126316: Make grp.getgrall() thread-safe: add a mutex #127055).cc: @mpage@colesbury@Yhg1s