Skip to content

gh-73065: Add Date header if missing in smtplib send_message#136850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Yoav11 wants to merge 15 commits into
base:main
Choose a base branch
from
Open

gh-73065: Add Date header if missing in smtplib send_message #136850

Yoav11 wants to merge 15 commits into from
+37 −13

Conversation

@Yoav11
Copy link
Contributor

@Yoav11Yoav11 commented Jul 20, 2025•
edited
Loading

Description

this PR was created during EuroPython 2025 Sprint Weekend.

It builds on #5176 authored by @elafontaine

📚 Documentation preview 📚: https://cpython-previews--136850.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-botbot commented Jul 20, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@Yoav11Yoav11 changed the title gh-28879: Add Date header if missing in smtplib send_messagebpo-28879: Add Date header if missing in smtplib send_messageJul 20, 2025
@StanFromIreland
Copy link
Member

StanFromIreland commented Jul 20, 2025

Please change the title to use the GitHub issue number.

@Yoav11Yoav11 changed the title bpo-28879: Add Date header if missing in smtplib send_messagegh-73065: Add Date header if missing in smtplib send_messageJul 20, 2025
@bedevere-appbedevere-appbot mentioned this pull request Jul 20, 2025
Open
@Yoav11Yoav11 marked this pull request as ready for review July 20, 2025 08:22
@Yoav11Yoav11 requested a review from a team as a code ownerJuly 20, 2025 08:22
ilovelinux
ilovelinux suggested changes Jul 20, 2025
View reviewed changes
ilovelinux
ilovelinux suggested changes Jul 20, 2025
View reviewed changes
Yoav11
Yoav11 commented Jul 20, 2025
View reviewed changes
Yoav11
Yoav11 commented Jul 20, 2025
View reviewed changes
Lib/test/test_smtplib.py
HOST, self.port, local_hostname='localhost',
timeout=support.LOOPBACK_TIMEOUT)
self.addCleanup(smtp.close)
self.assertEqual(smtp.send_message(msg),{})
Copy link
ContributorAuthor

@Yoav11Yoav11Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am moving these assertions further up so that I can extract the date from the message in order to build the expected string

ilovelinux
ilovelinux reviewed Jul 20, 2025
View reviewed changes
StanFromIreland
StanFromIreland reviewed Jul 20, 2025
View reviewed changes
@StanFromIreland
Copy link
Member

StanFromIreland commented Jul 20, 2025

@Yoav11 A little suggestion, when you complete a suggestion, whether that be by implementing it or providing a reason why you are not going to, please mark the conversation as "Resolved," this keeps the PR more organized.

ilovelinux
ilovelinux suggested changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@ilovelinuxilovelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider mocking the date with a non-UTC time of which we know the timezone

@StanFromIreland
Copy link
Member

StanFromIreland commented Jul 23, 2025

Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide.

ilovelinux
ilovelinux approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@ilovelinuxilovelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done

@ilovelinux
Copy link
Contributor

ilovelinux commented Aug 4, 2025

@StanFromIreland the PR should be ready to be merged

@ilovelinux
Copy link
Contributor

ilovelinux commented Sep 2, 2025

@StanFromIreland bump 🙂

@StanFromIreland
Copy link
Member

StanFromIreland commented Sep 2, 2025

The email experts have been requested, please be patient.

@ilovelinux
Copy link
Contributor

ilovelinux commented Sep 2, 2025

Thanks for the update 🙂

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

+2 more reviewers

@elafontaineelafontaineelafontaine left review comments

@ilovelinuxilovelinuxilovelinux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core reviewsprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yoav11@StanFromIreland@ilovelinux@elafontaine@tomasr8@ynir3