gh-124098: Fix incorrect inclusion of handler methods without protocol prefix in OpenerDirector#136873
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
encukou approved these changes Dec 18, 2025
encukou merged commit 1c544ac into python:main 47 checks passed
Uh oh!
There was an error while loading. Please reload this page.
cocolato pushed a commit to cocolato/cpython that referenced this pull request Dec 18, 2025
…rotocol prefix in OpenerDirector (pythonGH-136873)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolvesGH-124098 an issue where handler methods that did not start with a protocol name but matched a valid base handler method (e.g., _open() or error()) were mistakenly added to OpenerDirector's handlers.