Skip to content

gh-124111: test macOS CI with Tk 9#136959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ned-deily wants to merge 1 commit into from
Closed

gh-124111: test macOS CI with Tk 9 #136959

ned-deily wants to merge 1 commit into from

Conversation

@ned-deily
Copy link
Member

@ned-deilyned-deily commented Jul 22, 2025•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Jul 22, 2025
Open
@ezio-melottiezio-melotti mentioned this pull request Jul 22, 2025
Merged
@itamaro
Copy link
Contributor

itamaro commented Aug 3, 2025

@ned-deily should this be a draft PR?

@ned-deily
Copy link
MemberAuthor

ned-deily commented Aug 5, 2025

should this be a draft PR?

Sure, I guess. This PR was meant to just confirm that the macOS CI jobs using Tk 9.0 instead of Tk 8.6 have test failures that need to be resolved before we can move to 9.0. We need someone to work on them as discussed in the issue.

@ned-deilyned-deily marked this pull request as draft August 5, 2025 03:54
@hugovkhugovk mentioned this pull request Aug 5, 2025
Merged
@hugovk
Copy link
Member

hugovk commented Aug 5, 2025

I've included this PR and added tests in #137424. (I would have pushed here, but GitHub said this branch is protected.)

@ned-deily
Copy link
MemberAuthor

ned-deily commented Aug 5, 2025

I've included this PR and added tests in #137424. (I would have pushed here, but GitHub said this branch is protected.)

Thanks for the tests. I'm not sure why you couldn't push to this PR but it may have been due to today's reported Github problems earlier. Closing in favor of #137424.

@ned-deilyned-deily deleted the gh-124111-macos-ci-tk9 branch August 6, 2025 01:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@webknjazwebknjazAwaiting requested review from webknjazwebknjaz will be requested when the pull request is marked ready for reviewwebknjaz is a code owner

Assignees

No one assigned

Labels

DO-NOT-MERGEOS-macskip newstopic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ned-deily@itamaro@hugovk