[3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces…#137013
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…places a dataclass, make the original class collectible (pythonGH-136893) (python#136960)" This reverts commit 6e1b31b. Modifying the `__dict__` is likely to cause crashes
hugovk approved these changes Jul 22, 2025
Member
hugovk left a comment
hugovk left a comment There was a problem hiding this comment.
Thanks, let's revert this for RC1 and we'll consider another approach for RC2.
hugovk merged commit 70990ed into python:3.14 48 checks passed
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… a dataclass, make the original class collectible (GH-136893) (#136960)"
This reverts commit 6e1b31b.
Modifying the
__dict__is likely to cause crashes