gh-137065: Unmerge types.UnionType and typing.Union#137069
Draft
+168 −105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Partially revert pythonGH-105499. types.UnionType no longer an alias of typing.Union and no longer subscriptable, but subscribing typing.Union returns an instance of types.UnionType. typing.Union can no longer be used in the isinstance() checks.
serhiy-storchakaforce-pushed the typing-union branch from e57751f to fb8bc3eCompare
JelleZijlstra requested changes Jul 25, 2025
Member
JelleZijlstra left a comment
JelleZijlstra left a comment There was a problem hiding this comment.
I don't think anything should be changed here.
When you're done making the requested changes, leave the comment: |
| - Both syntaxes for creating a union now produce the same string representation in | ||
| ``repr()``. For example, ``repr(Union[int, str])`` | ||
| is now ``"int | str"`` instead of ``"typing.Union[int, str]"``. | ||
| - Unions created using the old syntax are no longer cached. Previously, running |
There was a problem hiding this comment.
Not sure why this was removed; the text would seem to still apply under this PR.
MemberAuthor
serhiy-storchaka commented Sep 16, 2025
I now think that we need a full revert. See #138967. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially revert GH-105499.
types.UnionType no longer an alias of typing.Union and no longer subscriptable, but subscribing typing.Union returns an instance of types.UnionType. typing.Union can no longer be used in the isinstance() checks.
typing._UnionGenericAlias, nottyping.Union#137065📚 Documentation preview 📚: https://cpython-previews--137069.org.readthedocs.build/