gh-136681: optimize builtin calls if kwargs allowed#137202
Closed
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first part, that should address #136681. With this patch there should be no overhead for function calls if it's signature allows keyword arguments.
Below are micro-benchmarks for math.fmin(), when only positional arguments are allowed (as in the main) vs positional-or-keyword.
The missing part is specialization for 1-arg functions, like cmath.sin(): #136681 (comment)
In the main:
Benchmark hidden because not significant (1): fmin(1.0, 2.0) x 10 times
With the patch:
Benchmark code: