Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islingtonmiss-islington commented Aug 10, 2025

Previously, DocTest's lineno of functions and methods decorated with
functools.cache(), functools.lru_cache() and functools.cached_property()
was not properly returned (None was returned) because the
computation relied on inspect.isfunction() which does not consider the
decorated result as a function.

We now use the more generic inspect.isroutine(), as elsewhere
in doctest's logic.

Also, added a special case for functools.cached_property().
(cherry picked from commit fece15d)

Co-authored-by: Denis Laxalde [email protected]

…cTest's lineno computation (pythonGH-136930) Previously, DocTest's lineno of functions and methods decorated with functools.cache(), functools.lru_cache() and functools.cached_property() was not properly returned (None was returned) because the computation relied on inspect.isfunction() which does not consider the decorated result as a function. We now use the more generic inspect.isroutine(), as elsewhere in doctest's logic. Also, added a special case for functools.cached_property(). (cherry picked from commit fece15d) Co-authored-by: Denis Laxalde <[email protected]>
@serhiy-storchakaserhiy-storchaka enabled auto-merge (squash) August 10, 2025 19:44
@serhiy-storchakaserhiy-storchaka merged commit 23b7a95 into python:3.13Aug 10, 2025
38 of 39 checks passed
@miss-islingtonmiss-islington deleted the backport-fece15d-3.13 branch January 2, 2026 19:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@miss-islington@serhiy-storchaka@dlax