GH-92266: Remove embedded tabs from c-analyzer/cpython/_parser.py#137622
+243 −259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
AA-Turner commented Aug 10, 2025
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner commented Aug 10, 2025
Uh oh!
There was an error while loading. Please reload this page.
ericsnowcurrently approved these changes Sep 17, 2025
Member
ericsnowcurrently left a comment
ericsnowcurrently left a comment There was a problem hiding this comment.
LGTM (with your own suggested changes applied)
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # Tools/c-analyzer/cpython/_parser.py
AA-Turner merged commit 2212ae5 into python:main 43 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2025
…r.py`` (pythonGH-137622) (cherry picked from commit 2212ae5) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-139718 is a backport of this pull request to the 3.14 branch. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to avoid some of the problems we've seen with embedded tabs by changing the global variables within
c-analyzer/cpython/_parser.pyto use more structured data.The output is identical, save for
INCL_DIRS, where the fourth line (* ./Include/internal/mimalloc) currently uses spaces instead of tabs, showing that the current format is quite hard to properly keep up to date. The errant line was added in #109914.What do you think @ericsnowcurrently?
See also: