Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Aug 12, 2025

Re: #137427 (review)

The 3.14 branch contains:

 Python 3.14b3 3625 (Fix handling of opcodes that may leave operands on the stack when optimizing LOAD_FAST) Python 3.14b5 3626 (Fix missing exception handlers in logical expression) 

Let's add them both here. And b5 should be rc2.

@miss-islington-app
Copy link

Thanks @hugovk for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @hugovk and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 715647a99ad91ebc77f3a250f6417c411116f33d 3.14 

@encukou
Copy link
Member

Sorry for the oversight.

@bedevere-app
Copy link

GH-137667 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Aug 12, 2025
@bedevere-app
Copy link

GH-137667 is a backport of this pull request to the 3.14 branch.

encukou pushed a commit to encukou/cpython that referenced this pull request Aug 12, 2025
(cherry picked from commit 715647a) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovkhugovk deleted the 3.14-fix-magic-number branch August 12, 2025 11:57
@hugovk
Copy link
MemberAuthor

No problem :)

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x (tier-3) has failed when building commit 715647a.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/3044) and take a look at the build logs.
  4. Check if the failure is related to this commit (715647a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/3044

Summary of the results of the build (if available):

Click to see traceback logs
remote: Enumerating objects: 9, done. remote: Counting objects: 11% (1/9) remote: Counting objects: 22% (2/9) remote: Counting objects: 33% (3/9) remote: Counting objects: 44% (4/9) remote: Counting objects: 55% (5/9) remote: Counting objects: 66% (6/9) remote: Counting objects: 77% (7/9) remote: Counting objects: 88% (8/9) remote: Counting objects: 100% (9/9) remote: Counting objects: 100% (9/9), done. remote: Compressing objects: 50% (1/2) remote: Compressing objects: 100% (2/2) remote: Compressing objects: 100% (2/2), done. remote: Total 5 (delta 4), reused 3 (delta 3), pack-reused 0 (from 0)  From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: switching to '715647a99ad91ebc77f3a250f6417c411116f33d'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at 715647a99ad gh-137288: Update 3.14 magic numbers (GH-137665) Switched to and reset branch 'main' configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal moduleconfigure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly. % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 192k 100 192k 0 0 1366k 0 --:--:-- --:--:-- --:--:-- 1366k % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 42455 100 42455 0 0 356k 0 --:--:-- --:--:-- --:--:-- 356k % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 2 5041k 2 109k 0 0 839k 0 0:00:06 --:--:-- 0:00:06 839k 100 5041k 100 5041k 0 0 24.8M 0 --:--:-- --:--:-- --:--:-- 70.8M % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1257k 100 1257k 0 0 10.7M 0 --:--:-- --:--:-- --:--:-- 10.7M % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 635k 100 635k 0 0 6147k 0 --:--:-- --:--:-- --:--:-- 6147k % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 479k 100 479k 0 0 3597k 0 --:--:-- --:--:-- --:--:-- 3597k ../../configure: line 4071: pkg-config: command not foundconfigure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal moduleconfigure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly. ../../Python/fileutils.c:460:1: warning: unused function 'decode_current_locale' [-Wunused-function] 460 | decode_current_locale(const char* arg, wchar_t **wstr, size_t *wlen, |^~~~~~~~~~~~~~~~~~~~~ ../../Python/fileutils.c:679:1: warning: unused function 'encode_current_locale' [-Wunused-function] 679 | encode_current_locale(const wchar_t *text, char **str, |^~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. ../../Modules/_localemodule.c:195:1: warning: unused function 'is_all_ascii' [-Wunused-function] 195 | is_all_ascii(const char *str) |^~~~~~~~~~~~ 1 warning generated. ../../Modules/pwdmodule.c:69:16: warning: unused variable 'pwd_db_mutex' [-Wunused-variable] 69 | static PyMutex pwd_db_mutex ={0}; |^~~~~~~~~~~~ 1 warning generated. ../../Modules/_hacl/Lib_Memzero0.c:66:6: warning: "Your platform does not support any safe implementation of memzero -- consider a pull request!" [-W#warnings] 66 | #warning "Your platform does not support any safe implementation of memzero -- consider a pull request!" |^ 1 warning generated. % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 8784 100 8784 0 0 50984 0 --:--:-- --:--:-- --:--:-- 51069 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 2894 100 2894 0 0 79205 0 --:--:-- --:--:-- --:--:-- 80388 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 43504 100 43504 0 0 1476k 0 --:--:-- --:--:-- --:--:-- 1517k

hugovk added a commit that referenced this pull request Aug 12, 2025
…7667) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
maurycy added a commit to maurycy/cpython that referenced this pull request Aug 12, 2025
* main: pythongh-137288: Update 3.14 magic numbers (pythonGH-137665) pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (take 2) (pythonGH-137047) pythongh-126008: Improve docstrings for Tkinter cget and configure methods (pythonGH-133303) pythongh-131885: Use positional-only markers for ``max()`` and ``min()`` (python#131868) pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (pythonGH-137567) pythongh-125897: Mark range function parameters as positional only (python#125945) pythongh-137400: Fix a crash when disabling profiling across all threads (pythongh-137471) pythongh-115766: Fix IPv4Interface.is_unspecified (pythonGH-137326) pythongh-128813: cleanup C-API docs for PyComplexObject (pythonGH-137579) pythongh-135953: Profile a module or script with sampling profiler (python#136777) Fix documentation of hash in PyHash_FuncDef (python#137595)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
…137665) (python#137667) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk@encukou@bedevere-bot