GH-137573: mark _PyOptimizer_Optimize as no inline

[inventshah]

Needs backport to 3.14.

• Issue: Stack overflow error from recursion with 3.14.0rc1 on MacOS #137573

[miss-islington-app]

Thanks @inventshah for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[bedevere-app]

GH-137751 is a backport of this pull request to the 3.14 branch.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Android 3.x (tier-3) has failed when building commit c9d7065.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1591/builds/2770) and take a look at the build logs.
4. Check if the failure is related to this commit (c9d7065) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1591/builds/2770

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 16, done. remote: Counting objects: 6% (1/16) remote: Counting objects: 12% (2/16) remote: Counting objects: 18% (3/16) remote: Counting objects: 25% (4/16) remote: Counting objects: 31% (5/16) remote: Counting objects: 37% (6/16) remote: Counting objects: 43% (7/16) remote: Counting objects: 50% (8/16) remote: Counting objects: 56% (9/16) remote: Counting objects: 62% (10/16) remote: Counting objects: 68% (11/16) remote: Counting objects: 75% (12/16) remote: Counting objects: 81% (13/16) remote: Counting objects: 87% (14/16) remote: Counting objects: 93% (15/16) remote: Counting objects: 100% (16/16) remote: Counting objects: 100% (16/16), done. remote: Compressing objects: 11% (1/9) remote: Compressing objects: 22% (2/9) remote: Compressing objects: 33% (3/9) remote: Compressing objects: 44% (4/9) remote: Compressing objects: 55% (5/9) remote: Compressing objects: 66% (6/9) remote: Compressing objects: 77% (7/9) remote: Compressing objects: 88% (8/9) remote: Compressing objects: 100% (9/9) remote: Compressing objects: 100% (9/9), done. remote: Total 9 (delta 7), reused 1 (delta 0), pack-reused 0 (from 0)  From https://github.com/python/cpython * branch main -> FETCH_HEAD Note: switching to 'c9d70651889afa89a033e8daedcb1cd60c59653a'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by switching back to a branch. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -c with the switch command. Example: git switch -c <new-branch-name> Or undo this operation with: git switch - Turn off this advice by setting config variable advice.detachedHead to false HEAD is now at c9d70651889 GH-137573: mark _PyOptimizer_Optimize as no inline (GH-137731) Switched to and reset branch 'main' configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal module In file included from ../../Include/internal/pycore_dict.h:11, from ../../Objects/typeobject.c:7: In function ‘Py_DECREF_MORTAL’, inlined from ‘PyStackRef_XCLOSE’ at ../../Include/internal/pycore_stackref.h:730:9, inlined from ‘_PyThreadState_PopCStackRef’ at ../../Include/internal/pycore_stackref.h:810:5, inlined from ‘vectorcall_maybe’ at ../../Objects/typeobject.c:3107:9: ../../Include/internal/pycore_object.h:481:8: warning: array subscript 0 is outside array bounds of ‘PyObject[0]’{aka ‘struct _object[]’} [-Warray-bounds] 481 | if (--op->ob_refcnt == 0){|^ % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 201k 100 201k 0 0 376k 0 --:--:-- --:--:-- --:--:-- 376k % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 43710 100 43710 0 0 103k 0 --:--:-- --:--:-- --:--:-- 103k % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 5095k 100 5095k 0 0 8654k 0 --:--:-- --:--:-- --:--:-- 8654k % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 1270k 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1270k 100 1270k 0 0 2834k 0 --:--:-- --:--:-- --:--:-- 68.9M % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 629k 100 629k 0 0 1509k 0 --:--:-- --:--:-- --:--:-- 1509k % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 511k 100 511k 0 0 1150k 0 --:--:-- --:--:-- --:--:-- 5744k configure: WARNING: no system libmpdec found; falling back to pure-Python version for the decimal module ../../Python/fileutils.c:460:1: warning: unused function 'decode_current_locale' [-Wunused-function] 460 | decode_current_locale(const char* arg, wchar_t **wstr, size_t *wlen, |^~~~~~~~~~~~~~~~~~~~~ ../../Python/fileutils.c:679:1: warning: unused function 'encode_current_locale' [-Wunused-function] 679 | encode_current_locale(const wchar_t *text, char **str, |^~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. ../../Modules/_localemodule.c:195:1: warning: unused function 'is_all_ascii' [-Wunused-function] 195 | is_all_ascii(const char *str) |^~~~~~~~~~~~ 1 warning generated. ../../Modules/pwdmodule.c:69:16: warning: unused variable 'pwd_db_mutex' [-Wunused-variable] 69 | static PyMutex pwd_db_mutex ={0}; |^~~~~~~~~~~~ 1 warning generated. ../../Modules/_hacl/Lib_Memzero0.c:66:6: warning: "Your platform does not support any safe implementation of memzero -- consider a pull request!" [-W#warnings] 66 | #warning "Your platform does not support any safe implementation of memzero -- consider a pull request!" |^ 1 warning generated. % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 8784 100 8784 0 0 43254 0 --:--:-- --:--:-- --:--:-- 43485 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 2894 100 2894 0 0 14294 0 --:--:-- --:--:-- --:--:-- 14256 100 2894 100 2894 0 0 14283 0 --:--:-- --:--:-- --:--:-- 14256 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 43504 100 43504 0 0 203k 0 --:--:-- --:--:-- --:--:-- 204k