gh-91484: Allow memoryview cast for F-contiguous#137803
Open
+32 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
All commit authors signed the Contributor License Agreement. |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
StanFromIreland left a comment
StanFromIreland left a comment There was a problem hiding this comment.
This change needs a NEWS entry, you can do it via the web interface (comment above) or with the blurb tool locally. You also have some trailing whitespace.
Author
jamie2779 commented Aug 15, 2025
@corona10 Please check my Pull Request |
Author
jamie2779 commented Aug 15, 2025
@StanFromIreland thank you! I added NEWS entry. |
Member
corona10 left a comment
corona10 left a comment There was a problem hiding this comment.
Please check lint status, looks like there is empty space in some line.
Author
jamie2779 commented Aug 15, 2025
Ok, I removed the trailing whitespace. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow N-D to 1-D memoryview cast for F-contiguous
memoryviews incast#91484