Skip to content

Conversation

@CarlosEduR
Copy link

@CarlosEduRCarlosEduR commented Aug 16, 2025

This PR updates the PyBuffer_FromContiguous function by renaming the fort parameter to order for clarity. The function's declaration in the header already uses order; this change updates all references in the implementation and documentation to match.

It also updates the declaration of the PyBuffer_IsContiguous function in the header by renaming fort to order. Its documentation and definition were already using order as the parameter name.


📚 Documentation preview 📚: https://cpython-previews--137866.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-botbot commented Aug 16, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

This comment was marked as resolved.

@picnixzpicnixz changed the title gh-137696: Rename 'fort' parameter to 'order' in PyBuffer_FromContiguousgh-137696: Rename 'fort' parameter to 'order' in PyBuffer_* functionsAug 18, 2025
@picnixz
Copy link
Member

picnixz commented Aug 18, 2025

Please see #137696 (comment) and change the functions (declarations and definitions) as well as the documentation so that all of them use 'order' instead of a mix of all. In addition, please sign the CLA.

@CarlosEduR
Copy link
Author

Please see #137696 (comment)

Thanks for the review, @picnixz. The functions and documentation have been updated.

@nybblista
Copy link
Contributor

Let's push this forward @CarlosEduR@picnixz

@CarlosEduR
Copy link
Author

Let's push this forward @CarlosEduR@picnixz

Can you review it again, @picnixz? I just merged main into this branch again to keep it up to date.

@CarlosEduRCarlosEduRforce-pushed the fix-issue-137696 branch 2 times, most recently from 420cd1a to 6bdf5abCompareNovember 20, 2025 15:07
@picnixzpicnixz requested review from picnixz and removed request for nybblistaJanuary 5, 2026 18:42
@CarlosEduR
Copy link
Author

Thanks for the review, @picnixz

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@CarlosEduR@picnixz@nybblista@ZeroIntensity