Skip to content

gh-116946: fully implement GC protocol for zlib objects#138290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
picnixz merged 5 commits into from
Sep 1, 2025
Merged

gh-116946: fully implement GC protocol for zlib objects #138290

picnixz merged 5 commits into from
Sep 1, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Aug 31, 2025•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Aug 31, 2025
Open
@picnixzpicnixz marked this pull request as draft August 31, 2025 12:33
@picnixzpicnixzforce-pushed the fix/gc/zlib-heap-types-116946 branch from 2c6983e to 62cba6fCompareAugust 31, 2025 13:00
@picnixzpicnixz marked this pull request as ready for review August 31, 2025 13:01
picnixz
picnixz commented Aug 31, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed Aug 31, 2025
View reviewed changes
@picnixzpicnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 1, 2025
@picnixzpicnixz merged commit 2a54acf into python:mainSep 1, 2025
51 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Sep 1, 2025

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented Sep 1, 2025

Sorry, @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2a54acf3c3d9f388c3d878a17ea804a801affca9 3.14

@picnixzpicnixz deleted the fix/gc/zlib-heap-types-116946 branch September 1, 2025 08:24
@miss-islington-app
Copy link

miss-islington-appbot commented Sep 1, 2025

Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2a54acf3c3d9f388c3d878a17ea804a801affca9 3.13

picnixz added a commit to picnixz/cpython that referenced this pull request Sep 1, 2025
@picnixz
[3.14]pythongh-116946: fully implement GC protocol forzlibobjects (
88cad1f
pythonGH-138290) (cherry picked from commit 2a54acf) Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Sep 1, 2025

GH-138327 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Sep 1, 2025
picnixz added a commit to picnixz/cpython that referenced this pull request Sep 1, 2025
@picnixz
[3.13]pythongh-116946: fully implement GC protocol forzlibobjects (
f32be72
pythonGH-138290) (cherry picked from commit 2a54acf) Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Sep 1, 2025

GH-138328 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Sep 1, 2025
picnixz added a commit that referenced this pull request Sep 1, 2025
@picnixz
[3.13]gh-116946: fully implement GC protocol forzlibobjects (GH-…
d25d2d6
…138290) (#138328) (cherry picked from commit 2a54acf)
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@picnixz@lkollar
pythongh-116946: fully implement GC protocol forzlibobjects (pyth…
99ec312
…on#138290)
hugovk pushed a commit that referenced this pull request Sep 12, 2025
@picnixz
[3.14]gh-116946: fully implement GC protocol forzlibobjects (GH-…
c8cc39d
…138290) (#138327)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

+1 more reviewer

@auvipyauvipyauvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@picnixzpicnixz

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz@auvipy@ZeroIntensity