Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-105487: Fix __dir__ entries of GenericAlias#138578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
sobolevn commented Sep 6, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
110e6b0 to 1eac463Compare
emmatyping left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion but otherwise I think this makes sense!
Misc/NEWS.d/next/Core_and_Builtins/2025-09-06-13-53-33.gh-issue-105487.a43YaY.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
emmatyping commented Sep 7, 2025
Should we backport this to 3.14 and 3.13? |
…e-105487.a43YaY.rst Co-authored-by: Emma Smith <[email protected]>
sobolevn commented Sep 7, 2025
Yes, we totally should! Thanks for the review :) |
b0420b5 into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…8578) (cherry picked from commit b0420b5) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Emma Smith <[email protected]>
Sorry, @sobolevn, I could not cleanly backport this to |
GH-138629 is a backport of this pull request to the 3.14 branch. |
sobolevn commented Sep 7, 2025
Will work on a 3.13 backport a bit later :) |
bedevere-bot commented Sep 7, 2025
|
…onGH-138578) (cherry picked from commit b0420b5) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Emma Smith <[email protected]>
GH-138640 is a backport of this pull request to the 3.13 branch. |
…#138640) (cherry picked from commit b0420b5) Co-authored-by: Emma Smith <[email protected]>
Co-authored-by: Emma Smith <[email protected]>
…GH-138629) (cherry picked from commit b0420b5) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Emma Smith <[email protected]>
Basically, there are two use-cases why we used
attr_exceptions:self.__origin__.ATTRself.ATTRoverself.__origin__.ATTRNow we have two arrays for just that.
Before:
After:
.symmetric_differenceof two:{'__deepcopy__', '__bases__', '__copy__'}Reasoning:
types.GenericAliashas extra__copy__and__deepcopy__in__dir__#105487