gh-116946: add Py_TPFLAGS_IMMUTABLETYPE to several internal types#138582
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only adds the
Py_TPFLAGS_IMMUTABLETYPEflag and assumes that other GC-related issues are solved (not all types are actually empty). I've added NEWS entries just because we also mention transforming extension modules from single-phase to multi-phase. It doesn't hurt mentioning this if a type can be observed withobj = public_func(); print(type(obj)).@serhiy-storchaka Can I split the PR for immutable types into those that are in
_test*apiandxxlimited*with those that are used in release builds? There is just one type_interpreters.CrossInterpreterBufferViewthat I'm unsure of.@pablogsal Am I correct to assume that
_remote_debugging.RemoteUnwindershould be immutable and is really internal? It's only "publicly" accessible throughprofiling.sampling.SampleProfiler.unwinderbut I don't know if it's meant to be used externally.