Skip to content

gh-57911: Fix failing symlink test#138626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 1 commit into from
Sep 8, 2025
Merged

gh-57911: Fix failing symlink test #138626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_tarfile.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3694,7 +3694,7 @@ def setUpClass(cls):
else:
raise AssertionError('Could not determine link resolution')
else:
cls.dotdot_resolves_early = True
cls.dotdot_resolves_early = False

@contextmanager
def check_context(self, tar, filter, *, check_flag=True):
Expand DownExpand Up@@ -3842,7 +3842,7 @@ def test_parent_symlink(self):
arc.add('current', symlink_to='.')

# effectively points to ./../
if self.dotdot_resolves_early:
if self.dotdot_resolves_early and os_helper.can_symlink():
arc.add('parent', symlink_to='current/../..')
else:
arc.add('parent', symlink_to='current/..')
Expand Down
Loading