gh-133143: Use _Py_ID for the other literals in sys#138698
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kumaraditya303 approved these changes Sep 9, 2025
encukou merged commit a92aec1 into python:main 85 of 87 checks passed
Uh oh!
There was an error while loading. Please reload this page.
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
…38698) Follow-up refactoring after pythonGH-133143, where we use `_Py_ID` for "big" and "little" in `abi_info.byteorder`. This uses `_Py_ID` for `sys.byteorder`, but also `float_repr_style` and a module name.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up refactoring after #133143, where we use
_Py_IDfor "big" and "little" inabi_info.byteorder.This uses
_Py_IDforsys.byteorder, but alsofloat_repr_styleand a module name.sys.abi_infoto make information about the interpreter ABI more accessible #133143