Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-138013: Remove load_tests in test_io.test_general#138771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
cmaloney commented Sep 10, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Rely on default test discovery. Validation: ```bash # Run before commit ./python -m test test_io -uall,walltime,largefile,cpu,extralargefile -M25G -o --fail-env-changed -j0 --list-cases | sort > old_cases.txt # Run after commit ./python -m test test_io -uall,walltime,largefile,cpu,extralargefile -M25G -o --fail-env-changed -j0 --list-cases | sort > new_cases.txt diff new_cases.txt old_cases. # <outputs no changes in case list> ```
f8509c3 to 60c4e8bComparecmaloney commented Sep 15, 2025
cc: @vstinner, once this is in, moving subsets of tests (bufferedio, textio, signals) just becomes copy/paste |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice cleanup.
ed75160 into python:mainUh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Sep 16, 2025
|
bedevere-bot commented Sep 16, 2025
|
cmaloney commented Sep 16, 2025
bedevere-bot commented Sep 16, 2025
|
bedevere-bot commented Sep 16, 2025
|
Rely on default test discovery.
Validation:
cc: @srittau (GH-138369 where a test was added but wasn't run because of the manual test list)