Skip to content

Conversation

@mhsmith
Copy link
Member

@mhsmithmhsmith commented Sep 11, 2025

#138649 and python/buildmaster-config#628 switched GitHub Actions and the buildbots over to using --fast-ci and --slow-ci on Android. However, this has introduced a warning, which has turned the buildbots orange:

Warning -- Failed to change Python options: FileNotFoundError(2, 'No such file or directory') Warning -- Command: -u -W error -bb --dont-add-python-opts 

Android runs the tests embedded in a larger app, so it's not possible to change the Python options by calling execv. Instead, this PR adds the ability to pass all Python command-line options to the Android testbed, so the options can be set to the expected values from the start.

This may also be useful in cibuildwheel, as it'll allow the testbed to accept a wider range of Python test commands (pypa/cibuildwheel#2590).

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly makes sense; a couple of minor clarification questions inline.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mhsmith
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-app
Copy link

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mhsmith
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-app
Copy link

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for those changes (and explanations) - looks like a solid set of improvements.

@freakboy3742freakboy3742 merged commit a9b0506 into python:mainOct 6, 2025
90 of 95 checks passed
@miss-islington-app
Copy link

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
…e options (pythonGH-138805) Modifies the Android test runner to ensure that all valid Python command line options are preserved when running the test suite. (cherry picked from commit a9b0506) Co-authored-by: Malcolm Smith <smith@chaquo.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
…e options (pythonGH-138805) Modifies the Android test runner to ensure that all valid Python command line options are preserved when running the test suite. (cherry picked from commit a9b0506) Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app
Copy link

GH-139637 is a backport of this pull request to the 3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14 bugs and security fixes label Oct 6, 2025
@bedevere-app
Copy link

GH-139638 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Oct 6, 2025
freakboy3742 pushed a commit that referenced this pull request Oct 6, 2025
…ne options (GH-138805) (#139638) Modifies the Android test runner to ensure that all valid Python command line options are preserved when running the test suite. (cherry picked from commit a9b0506) Co-authored-by: Malcolm Smith <smith@chaquo.com>
hugovk pushed a commit that referenced this pull request Oct 6, 2025
…ne options (GH-138805) (#139637) Co-authored-by: Malcolm Smith <smith@chaquo.com>
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
…e options (python#138805) Modifies the Android test runner to ensure that all valid Python command line options are preserved when running the test suite.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mhsmith@freakboy3742@emmatyping@picnixz