gh-138804: Check type in shlex.quote#138809
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
picnixz reviewed Sep 11, 2025
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Library/2025-09-12-01-01-05.gh-issue-138804.46ZukT.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
picnixz approved these changes Sep 11, 2025
Member
picnixz left a comment
picnixz left a comment There was a problem hiding this comment.
LGTM. I won't have time for merging this so I'll let @AA-Turner check English as well for the formulation.
StanFromIreland approved these changes Sep 12, 2025
Misc/NEWS.d/next/Library/2025-09-12-01-01-05.gh-issue-138804.46ZukT.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ZeroIntensity approved these changes Sep 12, 2025
ZeroIntensity merged commit 220c0a8 into python:main 45 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Thanks @wiomoc for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2025
(cherry picked from commit 220c0a8) Co-authored-by: Christoph Walcher <[email protected]>
GH-138846 is a backport of this pull request to the 3.14 branch. |
hugovk pushed a commit that referenced this pull request Sep 13, 2025
Co-authored-by: Christoph Walcher <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.