Skip to content

gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()#139396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Wulian233 wants to merge 8 commits into
base:main
Choose a base branch
from
Open

gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()#139396

Wulian233 wants to merge 8 commits into from

Conversation

@Wulian233
Copy link
Contributor

@Wulian233Wulian233 commented Sep 28, 2025•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot added awaiting review docs Documentation in the Doc dir skip news labels Sep 28, 2025
@bedevere-appbedevere-appbot mentioned this pull request Sep 28, 2025
Closed
AA-Turner

This comment was marked as outdated.

Sign in to view

@bedevere-app

This comment was marked as outdated.

Sign in to view
@Wulian233

This comment was marked as outdated.

Sign in to view
@AA-Turner
Copy link
Member

AA-Turner commented Oct 3, 2025

Ok, I'm proposing to remove that note from the 'A new type of interpreter' section, and I've also made the envvar change in the 'New & improved modules' PR. Could you retarget this PR to just make the zipfile.rst change?

A

@Wulian233Wulian233 changed the title gh-123299: Copyedit What's New in 3.14gh-123299: Copyedit What's New in zipfile.rstOct 3, 2025
@AA-TurnerAA-Turner changed the title gh-123299: Copyedit What's New in zipfile.rstgh-123299: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()Oct 3, 2025
@Wulian233
Copy link
ContributorAuthor

Wulian233 commented Oct 3, 2025

Could you retarget this PR to just make the zipfile.rst change?

Finished, thank you!

AA-Turner
AA-Turner requested changes Oct 4, 2025
View reviewed changes
@AA-TurnerAA-Turner changed the title gh-123299: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()Note SOURCE_DATE_EPOCH support in ZipFile.writestr()Oct 4, 2025
@vstinnervstinner changed the title Note SOURCE_DATE_EPOCH support in ZipFile.writestr()gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()Nov 4, 2025
@bedevere-appbedevere-appbot mentioned this pull request Nov 4, 2025
Closed
vstinner
vstinner reviewed Nov 4, 2025
View reviewed changes
@Wulian233@vstinner
Update Doc/library/zipfile.rst
217b831
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but English is not my first language, so I'm not sure about the sentence :-)

@Wulian233
Copy link
ContributorAuthor

Wulian233 commented Dec 15, 2025

@AA-Turner Could we merge it?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

Assignees

No one assigned

Labels

awaiting mergedocsDocumentation in the Doc dirskip news

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Wulian233@AA-Turner@vstinner