Skip to content

Conversation

@hartwork
Copy link
Contributor

@hartworkhartwork commented Sep 29, 2025

@bedevere-appbedevere-appbot added awaiting review tests Tests in the Lib/test dir labels Sep 29, 2025
@picnixz
Copy link
Member

Ah sorry, I should have explained for typos. In general, we don't fix typos that are not user-facing (that is, we only fix typos in docstrings, docs, error messages, etc, but usually, we don't fix typos in comments; that's to avoid having to backport them and to avoid code churn). If we were to rewrite the fnmatch() tests, then we would fix the typo because it's code that we would touch. Sorry, but this one won't be merged (we don't have an exact policy for typos... it's at the discretion of core devs, and the policy I take is shared by other core devs)

@hartwork
Copy link
ContributorAuthor

@picnixz that's fair, I understand, no worries 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviewtestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hartwork@picnixz