gh-135953: Add GIL contention markers to sampling profiler Gecko format#139485
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pablogsal requested review from 1st1, ZeroIntensity, ambv and ericsnowcurrently as code owners
…o format This commit enhances the Gecko format reporter in the sampling profiler to include markers for GIL acquisition events. The implementation adds: - GIL contention tracking in pystate and ceval_gil - New marker types in the Gecko collector for GIL wait events - External inspection support for reading GIL state - Sample collection of GIL acquisition times and thread states - Comprehensive tests for marker export functionality The markers provide visibility into GIL contention patterns, showing when threads are waiting to acquire the GIL and how long they wait.
MemberAuthor
pablogsal commented Oct 1, 2025
 |
pablogsal merged commit 89a914c into python:main 44 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
…o format (python#139485) This commit enhances the Gecko format reporter in the sampling profiler to include markers for GIL acquisition events.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enhances the Gecko format reporter in the sampling profiler
to include markers for GIL acquisition events. The implementation adds:
The markers provide visibility into GIL contention patterns, showing
when threads are waiting to acquire the GIL and how long they wait.