Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-70765: avoid waiting for HTTP headers when parsing HTTP/0.9 requests#139514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
3 commits Select commit Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -302,6 +302,7 @@ def parse_request(self): | ||
| error response has already been sent back. | ||
| """ | ||
| is_http_0_9 = False | ||
| self.command = None # set in case of error on the first line | ||
| self.request_version = version = self.default_request_version | ||
| self.close_connection = True | ||
| @@ -359,6 +360,7 @@ def parse_request(self): | ||
| HTTPStatus.BAD_REQUEST, | ||
| "Bad HTTP/0.9 request type (%r)" % command) | ||
| return False | ||
| is_http_0_9 = True | ||
| self.command, self.path = command, path | ||
| # gh-87389: The purpose of replacing '//' with '/' is to protect | ||
| @@ -368,6 +370,11 @@ def parse_request(self): | ||
| if self.path.startswith('//'): | ||
| self.path = '/' + self.path.lstrip('/') # Reduce to a single / | ||
| # For HTTP/0.9, headers are not expected at all. | ||
| if is_http_0_9: | ||
picnixz marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading. Please reload this page. | ||
| self.headers ={} | ||
| return True | ||
| # Examine the headers and look for a Connection directive. | ||
| try: | ||
| self.headers = http.client.parse_headers(self.rfile, | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions 5 Misc/NEWS.d/next/Library/2025-10-02-17-40-10.gh-issue-70765.zVlLZn.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| :mod:`http.server`: fix default handling of HTTP/0.9 requests in | ||
| :class:`~http.server.BaseHTTPRequestHandler`. Previously, | ||
| :meth:`!BaseHTTPRequestHandler.parse_request`` incorrectly | ||
| waited for headers in the request although those are not | ||
| supported in HTTP/0.9. Patch by Bénédikt Tran. |
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.